Foros del Web » Programando para Internet » PHP »

Escribir de otra forma estas lineas

Estas en el tema de Escribir de otra forma estas lineas en el foro de PHP en Foros del Web. Hola , escribo este post porque tengo este php , el cual esta programado con zend framework y pdo_mysql , me gustaria saber si existe ...
  #1 (permalink)  
Antiguo 01/06/2011, 14:01
 
Fecha de Ingreso: mayo-2010
Mensajes: 19
Antigüedad: 13 años, 11 meses
Puntos: 0
Escribir de otra forma estas lineas

Hola , escribo este post porque tengo este php , el cual esta programado con zend framework y pdo_mysql , me gustaria saber si existe otra manera de escribir estas lineas sin afectar el funcionamiento del mismo.

Código:
$pages = array( "login" => "login.php", "home" => "home.php", "account" => "account.php", "addptc" => "new_ptc.php", "addfad" => "new_fad.php", "addflink" => "new_flink.php", "addbannerad" => "new_bannerad.php", "manageptc" => "manage_ptc.php", "editptc" => "edit_ptc.php", "managefad" => "manage_fad.php", "editfad" => "edit_fads.php", "manageflink" => "manage_flink.php", "editflink" => "edit_flink.php", "managebannerad" => "manage_bannerad.php", "editbannerad" => "edit_bannerads.php", "members" => "members.php", "addmember" => "new_member.php", "editmember" => "edit_member.php", "massmail" => "mass_mail.php", "logout" => "logout.php", "optimizemembers" => "optimize_members.php", "withdrawals" => "withdrawals.php", "orders" => "orders.php", "news" => "news.php", "submitnews" => "submit_news.php", "editnews" => "edit_news.php", "faq" => "faq.php", "newfaq" => "new_faq.php", "editfaq" => "edit_faq.php", "bannedips" => "banned_ips.php", "bannedemails" => "banned_emails.php", "bannedcountries" => "banned_countries.php", "bannedusernames" => "banned_usernames.php", "backup" => "backup.php", "general" => "general_settings.php", "captcha" => "captcha_settings.php", "automation" => "automation_settings.php", "gateways" => "gateways_settings.php", "ptcads_settings" => "ptc_settings.php", "fads_settings" => "fads_settings.php", "flinks_settings" => "flinks_settings.php", "bannerads_settings" => "bannerads_settings.php", "membership" => "membership_settings.php", "withdraw" => "withdraw_settings.php", "buy_referrals" => "buyreferrals_settings.php", "rent_referrals" => "rentreferrals_settings.php", "forum_settings" => "forum_settings.php", "multipleips" => "multiple_ips.php", "googleanalytics" => "googleanalytics.php", "linktracker" => "linktracker.php", "assignreferral" => "assignreferral.php", "topdomains" => "topdomains.php", "specialpacks_settings" => "specialpacks_settings.php", "specialpacks_edit" => "specialpacks_edit.php", "install_language" => "install_language.php", "language_settings" => "language_settings.php", "install_template" => "install_template.php", "template_settings" => "template_settings.php", "admin_advertisement" => "admin_advertisement.php", "ptsu_settings" => "ptsu_settings.php", "manageptsu" => "manage_ptsu.php", "editptsu" => "edit_ptsu.php", "addptsu" => "new_ptsu.php", "ptsu_pending" => "ptsu_pending.php", "cheat_logs" => "cheat_logs.php" );
if ( isset( $_GET['view'], $pages[$_GET['view']] ) )
{
    include( "admin/home.php" );
}
else
{
    include( "admin/".$pages[$_GET['view']] );
}
  #2 (permalink)  
Antiguo 01/06/2011, 15:06
Avatar de gysato  
Fecha de Ingreso: junio-2010
Ubicación: Tuxtla Gtz, Chiapas
Mensajes: 88
Antigüedad: 13 años, 10 meses
Puntos: 9
Respuesta: Escribir de otra forma estas lineas

jajaja quitando los corchetes { y } jajajaja esta muy simple el codigo
  #3 (permalink)  
Antiguo 01/06/2011, 16:06
 
Fecha de Ingreso: julio-2009
Mensajes: 72
Antigüedad: 14 años, 8 meses
Puntos: 16
Respuesta: Escribir de otra forma estas lineas

No se como es la estructura de tu aplicación, pero a priori te puedo decir que ese codigo me huele muy feo sobre todo porque dices que estas usando Zend Framework

Te aconsejo que leas sobre el modelo mvc de zend frammework y sobre los router.

Estoy bastante seguro que sabiendo esas herramientas puedes hacer algo mucho mas optimo y escalable.

saludos!
__________________
Desarrollo de proyectos web
Cursos en Argentina - Cursos en México
  #4 (permalink)  
Antiguo 01/06/2011, 17:29
 
Fecha de Ingreso: mayo-2010
Mensajes: 19
Antigüedad: 13 años, 11 meses
Puntos: 0
Respuesta: Escribir de otra forma estas lineas

Hola , gracias por su ayuda , esas lineas hacen parte de un php mucho mas grande , pero publique solo esa parte porque es la unica que no funciona en el script , cuando intendo ejecutar el php en cualquier navegador me avisa que especificamente esta linea tiene error :

Código:
include( "admin/".$pages[$_GET['view']] );
El error se basa especificamente que la variable $pages no carga a las paginas correspondientes.

Este es el php completo :

Código:
<?php
/**
*
define( "Script", 1 );
session_start( );
require_once( "includes/checkversion.php" );
if ( !isset( $license_key ) )
{
    header( "location: install/install.php" );
    exit( );
}
if ( $real_version != $software['version'] )
{
    header( "location: install/upgrade.php" );
    exit( );
}
require_once( "includes/functions.php" );
require_once( "includes/adfunctions.php" );
require_once( "Zend/Loader/Autoloader.php" );
$autoloader = Zend_Loader_Autoloader::getinstance( );
$autoloader->setFallbackAutoloader( TRUE );
$pdoParams = array( TRUE );
$parametros = array(
    "host" => $db_server,
    "username" => $db_user,
    "password" => $db_passwd,
    "dbname" => $db_name,
    "driver_options" => $pdoParams
);
$db = Zend_Db::factory( "PDO_MYSQL", $parametros );
if ( count( $software ) != 1 )
{
    exit( "Some files necessary to this sofware do not exist or they were modified by a third party" );
}
$query = $db->query( "SELECT * FROM settings" );
while ( $result = $query->fetch( ) )
{
    $settings[$result['field']] = $result['value'];
}
if ( isset( $_SESSION['admin_username'], $_SESSION['admin_password'] ) )
{
    $res = $db->fetchOne( "SELECT COUNT(*) AS NUM FROM admin WHERE username='".$_SESSION['admin_username']."'" );
    if ( $res == 0 )
    {
        logout( );
        header( "location: admin.php" );
        exit( );
    }
    $user_info = $db->fetchRow( "SELECT * FROM admin WHERE username='".$_SESSION['admin_username']."'" );
    if ( $_SESSION['admin_password'] != $user_info['password'] )
    {
        logout( );
        header( "location: admin.php" );
        exit( );
    }
    $_SESSION['logged'] = "yes";
}
else
{
    unset( $_SESSION['logged'] );
}
if ( $_SESSION['logged'] == "yes" )
{
    $notes = $user_info['notes'];
    if ( $_REQUEST['action'] == "savenotes" )
    {
        $mynotes = cleanfrm( $_POST['mynotes'] );
        $upd = array(
            "notes" => $mynotes
        );
        $update = $db->update( "admin", $upd, "id='".$user_info['id']."'" );
        exit( "ok" );
    }
}
$pages = array( "login" => "login.php", "home" => "home.php", "account" => "account.php", "addptc" => "new_ptc.php", "addfad" => "new_fad.php", "addflink" => "new_flink.php", "addbannerad" => "new_bannerad.php", "manageptc" => "manage_ptc.php", "editptc" => "edit_ptc.php", "managefad" => "manage_fad.php", "editfad" => "edit_fads.php", "manageflink" => "manage_flink.php", "editflink" => "edit_flink.php", "managebannerad" => "manage_bannerad.php", "editbannerad" => "edit_bannerads.php", "members" => "members.php", "addmember" => "new_member.php", "editmember" => "edit_member.php", "massmail" => "mass_mail.php", "logout" => "logout.php", "optimizemembers" => "optimize_members.php", "withdrawals" => "withdrawals.php", "orders" => "orders.php", "news" => "news.php", "submitnews" => "submit_news.php", "editnews" => "edit_news.php", "faq" => "faq.php", "newfaq" => "new_faq.php", "editfaq" => "edit_faq.php", "bannedips" => "banned_ips.php", "bannedemails" => "banned_emails.php", "bannedcountries" => "banned_countries.php", "bannedusernames" => "banned_usernames.php", "backup" => "backup.php", "general" => "general_settings.php", "captcha" => "captcha_settings.php", "automation" => "automation_settings.php", "gateways" => "gateways_settings.php", "ptcads_settings" => "ptc_settings.php", "fads_settings" => "fads_settings.php", "flinks_settings" => "flinks_settings.php", "bannerads_settings" => "bannerads_settings.php", "membership" => "membership_settings.php", "withdraw" => "withdraw_settings.php", "buy_referrals" => "buyreferrals_settings.php", "rent_referrals" => "rentreferrals_settings.php", "forum_settings" => "forum_settings.php", "multipleips" => "multiple_ips.php", "googleanalytics" => "googleanalytics.php", "linktracker" => "linktracker.php", "assignreferral" => "assignreferral.php", "topdomains" => "topdomains.php", "specialpacks_settings" => "specialpacks_settings.php", "specialpacks_edit" => "specialpacks_edit.php", "install_language" => "install_language.php", "language_settings" => "language_settings.php", "install_template" => "install_template.php", "template_settings" => "template_settings.php", "admin_advertisement" => "admin_advertisement.php", "ptsu_settings" => "ptsu_settings.php", "manageptsu" => "manage_ptsu.php", "editptsu" => "edit_ptsu.php", "addptsu" => "new_ptsu.php", "ptsu_pending" => "ptsu_pending.php", "cheat_logs" => "cheat_logs.php" );
if ( isset( $_GET['view'], $pages[$_GET['view']] ) )
{
    include( "admin/home.php" );
}
else
{
    include( "admin/".$pages[$_GET['view']] );
}
$db->closeConnection( );
exit( );
?>
Si alguien puede escribir essas lineas que tiene error de otra forma para que finalmente la variable $pages funcione es de gran ayuda.
Muchas Gracias.
  #5 (permalink)  
Antiguo 01/06/2011, 18:13
 
Fecha de Ingreso: julio-2009
Mensajes: 72
Antigüedad: 14 años, 8 meses
Puntos: 16
Respuesta: Escribir de otra forma estas lineas

no sera asi?:

if ( isset( $_GET['view'], $pages[$_GET['view']] ) )
{
include( "admin/".$pages[$_GET['view']] );
}
else
{
include( "admin/home.php" );
}
__________________
Desarrollo de proyectos web
Cursos en Argentina - Cursos en México

Etiquetas: lineas, formulario
Atención: Estás leyendo un tema que no tiene actividad desde hace más de 6 MESES, te recomendamos abrir un Nuevo tema en lugar de responder al actual.
Respuesta




La zona horaria es GMT -6. Ahora son las 05:59.